add taproot wallet descriptors with AddressType enum
#674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stark-3k
force-pushed
the
add-taproot-wallet-descriptors
branch
from
498dc03 to
54ebebd
Compare
fix doc clippy and cli defaults to P2WPKH address fix coin selection bug and use taproot change addresses
stark-3k
force-pushed
the
add-taproot-wallet-descriptors
branch
from
54ebebd to
3269506
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 68.87% 77.58% +8.70%
==========================================
Files 35 49 +14
Lines 4932 14990 +10058
==========================================
+ Hits 3397 11630 +8233
- Misses 1535 3360 +1825 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mojoX911
reviewed
Dec 31, 2025
mojoX911
left a comment
mojoX911
left a comment
There was a problem hiding this comment.
Mostly looks good. One questions below.
Also does it makes sense to make all transactions taproot by default now that the wallet can handle both?
mojoX911
reviewed
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
AddressTypeenum to specify the type of address generation for various usecasesP2WPKHfor v1 protocol and usesP2TRfor v2 protocol